Repository nuxt.js

[edge] html minify issue

yoyo837
63
yoyo837
commented 3 months ago

Version

edge

Reproduction link

https://github.com/yoyo837/nuxt-3392

Steps to reproduce

See https://github.com/nuxt/nuxt.js/pull/3392#issuecomment-393863232

What is expected ?

HTML minify work fine.

What is actually happening?

It report error.

bug
0
yoyo837
63
yoyo837
commented 3 months ago

@pi0 I have new discoveries:

Using yarn install dependencies does not work, but npm can.

Yarn: 1.7.0

Node: 8.11.1

0
aldarund
69
aldarund
commented 3 months ago

Strange things. For me it works fine on my real project with latest nuxt-edge. But the example above just give empty error message. All with yarn
https://i.imgur.com/TDeLt96.png

0
yoyo837
63
yoyo837
commented 3 months ago

@aldarund Please take a look at what is wrong with your page, not just console.

0
aldarund
69
aldarund
commented 3 months ago

@yoyo837 ye i see it now. Although still all works fine with my real project with same version of nuxt :))

0
yoyo837
63
yoyo837
commented 3 months ago

@aldarund Are you sure all with yarn?And what’s the version of yarn?

0
aldarund
69
aldarund
commented 3 months ago

@yoyo837 yes, all with yarn. Im sure because i did a lot of full delete & reinstall yesterday
1.7.0

0
cristijora
5
cristijora
commented 2 months ago

Encountered the same issue today

0
rdunk
0
rdunk
commented 2 months ago

I encountered this and it seems to have been related to an older version of the html-minifier package. Forcing an update to the latest version seems to resolve it. In my case 3.5.10 was specified in my package-lock.json and now I'm using 3.5.16.

0
manniL
759
manniL
commented 13 days ago

Cannot reproduce this with [email protected]. If you can, please ping me @tim-yao

0
yoyo837
63
yoyo837
commented 13 days ago

No,This problem still exists until now. I'm very sure.
image

0
manniL
759
manniL
commented 13 days ago

@yoyo837 reopened.

0
manniL
759
manniL
commented 13 days ago

@yoyo837 Can't reproduce it with your repo linked in the issues and after updating 🤔

Could you give a details reproduction instruction?

0
yoyo837
63
yoyo837
commented 13 days ago

@manniL That is a repo small enough to reproduce the problem. This is caused by the #3392 merged, but that PR is trying to fix another issue. Now I'm not sure whether it should be revert.

0
yoyo837
63
yoyo837
commented 13 days ago

I have been having this problem since that PR was merged, every time.

0
manniL
759
manniL
commented 13 days ago

@yoyo837 I cloned the repo, updated the dependencies and was able to build nuxt without problems.

0
yoyo837
63
yoyo837
commented 13 days ago

See comment: https://github.com/nuxt/nuxt.js/issues/3411#issuecomment-394224616

Which pkg manager do you use? npm or yarn ? Use npm is work fine.

0
manniL
759
manniL
commented 12 days ago

Missed the comment. However, if NPM works but yarn doesn't, are you sure it's a Nuxt bug then?

0
aldarund
69
aldarund
commented 12 days ago

@mannil well, even if it's yarn bug it still should work for people who are using yarn via some workaround. It also might be a bug in npm that make it work fine, but not as it should :)
It must be something with resolving nested dependency difference on yarn vs npm

0
Atinux
18.9k
Atinux
commented 12 days ago

Will look into it

0
yoyo837
63
yoyo837
commented 11 days ago
yarn upgrade

This command can make it work fine.

0
Informations
Bug ReportFixed
#c7197 - Created 3 months ago